Merge ~cgrabowski/maas:fix_counting_ha_vlans into maas:master

[Christian Grabowski]

handle unlinked interfaces when counting HA VLANs

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix_counting_ha_vlans lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/278/consoleText
COMMIT: ea45233cce0dc3e9b988d7eead509057ec67ddd7

review: Needs Fixing

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix_counting_ha_vlans lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 41d390ea77d6c956961e54d77d593f6131c013fe

review: Approve

[Alexsander de Souza (alexsander-souza)]

+1

review: Approve

diff --git a/src/maasserver/websockets/handlers/controller.py b/src/maasserver/websockets/handlers/controller.py
index 609526a..193cf2f 100644
--- a/src/maasserver/websockets/handlers/controller.py
+++ b/src/maasserver/websockets/handlers/controller.py
@@ -172,6 +172,7 @@ class ControllerHandler(NodeHandler):
         vlan_ids = [
             interface.vlan_id
             for interface in obj.current_config.interface_set.all()
+            if interface.vlan_id is not None
         ]
         for vlan_id in vlan_ids:
             vlan_counts[self._vlans_ha[vlan_id]] += 1
diff --git a/src/maasserver/websockets/handlers/tests/test_controller.py b/src/maasserver/websockets/handlers/tests/test_controller.py
index 692f01d..433953b 100644
--- a/src/maasserver/websockets/handlers/tests/test_controller.py
+++ b/src/maasserver/websockets/handlers/tests/test_controller.py
@@ -507,3 +507,19 @@ class TestControllerHandler(MAASServerTestCase):
         handler.update_interface(request)
         controller.refresh_from_db()
         self.assertEqual(controller.boot_interface.vlan, vlan)
+
+    def test_count_HA_vlans_with_unlinked_interfaces(self):
+        admin = factory.make_admin()
+        handler = ControllerHandler(admin, {}, None)
+        primary = factory.make_RegionRackController()
+        primary.current_config.interface_set.add(
+            factory.make_Interface(link_connected=False)
+        )
+        secondary = factory.make_RackController()
+        factory.make_VLAN(primary_rack=primary, secondary_rack=secondary)
+        factory.make_VLAN(primary_rack=primary)
+        output = handler.get({"system_id": primary.system_id})
+        self.assertEqual(output["vlans_ha"]["true"], 1)
+        self.assertEqual(
+            output["vlans_ha"]["false"], 2
+        )  # default interface and the one linked to vlan2