Code review comment for ~cgrabowski/maas:do_not_create_duplicate_vlan_on_controller_report_neighbors

Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

I think the other testcases in TestReportVID must be updated also, because it looks like `neighbour["ip"]` won't be None usually. If you do this change, I think test_creates_vlan_if_necessary() will fail

review: Needs Information

« Back to merge proposal