Merge ~cgrabowski/maas:fix_vmcluster_full_dehydrate into maas:master

Proposed by Christian Grabowski
Status: Merged
Approved by: Christian Grabowski
Approved revision: 174b727a06ac07443f32d9a7132cd2ee92e4b376
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~cgrabowski/maas:fix_vmcluster_full_dehydrate
Merge into: maas:master
Diff against target: 45 lines (+23/-0)
2 files modified
src/maasserver/websockets/handlers/tests/test_vmcluster.py (+18/-0)
src/maasserver/websockets/handlers/vmcluster.py (+5/-0)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Alexsander de Souza Approve
Review via email: mp+410951@code.launchpad.net

Commit message

have vmcluster's websocket handler call its dehydrate on full_dehydrate

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b fix_vmcluster_full_dehydrate lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/11381/console
COMMIT: 16c73095bc0c30e45537a46ca0b1720c6797e48e

review: Needs Fixing
Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b fix_vmcluster_full_dehydrate lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 174b727a06ac07443f32d9a7132cd2ee92e4b376

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/websockets/handlers/tests/test_vmcluster.py b/src/maasserver/websockets/handlers/tests/test_vmcluster.py
2index 97ca628..f9dbe08 100644
3--- a/src/maasserver/websockets/handlers/tests/test_vmcluster.py
4+++ b/src/maasserver/websockets/handlers/tests/test_vmcluster.py
5@@ -151,6 +151,24 @@ class TestVMClusterHandler(MAASTransactionServerTestCase):
6 result["total_resources"]["storage_pools"][name]["free"],
7 )
8
9+ def test_full_dehydrate(self):
10+ cluster = factory.make_VMCluster(pods=3)
11+ vmhosts = cluster.hosts()
12+ _ = [factory.make_PodStoragePool(pod=vmhost) for vmhost in vmhosts]
13+
14+ vms = [
15+ factory.make_VirtualMachine(
16+ bmc=vmhost.as_bmc(), machine=factory.make_Machine()
17+ )
18+ for vmhost in vmhosts
19+ ]
20+
21+ handler = VMClusterHandler(factory.make_admin(), {}, None)
22+
23+ result = handler.full_dehydrate(cluster)
24+
25+ self._assert_dehydrated_cluster_equal(result, cluster, vmhosts, vms)
26+
27 def test_dehydrate(self):
28 cluster = factory.make_VMCluster(pods=0)
29 vmhosts = [factory.make_Pod(cluster=cluster) for _ in range(3)]
30diff --git a/src/maasserver/websockets/handlers/vmcluster.py b/src/maasserver/websockets/handlers/vmcluster.py
31index 7ed0ac2..2b08605 100644
32--- a/src/maasserver/websockets/handlers/vmcluster.py
33+++ b/src/maasserver/websockets/handlers/vmcluster.py
34@@ -73,6 +73,11 @@ class VMClusterHandler(TimestampedModelHandler):
35 },
36 }
37
38+ def full_dehydrate(self, obj, for_list=False):
39+ return self.dehydrate(
40+ obj, obj.hosts(), obj.total_resources(), obj.virtual_machines()
41+ )
42+
43 def dehydrate(self, cluster, vmhosts, resources, vms):
44 return {
45 "id": cluster.id,

Subscribers

People subscribed via source and target branches