Merge ~cgrabowski/maas:name_cluster_project_vmhost_uniqueness into maas:master

[Christian Grabowski]

change pod name uniqueness to either unqiue or unique within a LXD
project

[MAAS Lander (maas-lander)]

UNIT TESTS
-b name_cluster_project_vmhost_uniqueness lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/11378/console
COMMIT: 41bd50d66948f45921863b3a49578e49a162829e

review: Needs Fixing

[MAAS Lander (maas-lander)]

UNIT TESTS
-b name_cluster_project_vmhost_uniqueness lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/11379/console
COMMIT: 9dcf715970dc813ffa6990921320185e6166ada1

review: Needs Fixing

[Alexsander de Souza (alexsander-souza)]

+1

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b name_cluster_project_vmhost_uniqueness lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 2075956ed467e48a4b49beb3d155f3688b27e524

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b name_cluster_project_vmhost_uniqueness lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/11383/consoleText

[MAAS Lander (maas-lander)]

LANDING
-b name_cluster_project_vmhost_uniqueness lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/11385/consoleText

diff --git a/src/maasserver/migrations/maasserver/0251_auto_20211027_2128.py b/src/maasserver/migrations/maasserver/0251_auto_20211027_2128.py
new file mode 100644
index 0000000..78d667d
--- /dev/null
+++ b/src/maasserver/migrations/maasserver/0251_auto_20211027_2128.py
@@ -0,0 +1,26 @@
+# Generated by Django 2.2.12 on 2021-10-27 21:28
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("maasserver", "0250_node_last_applied_storage_layout"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="bmc",
+            name="name",
+            field=models.CharField(blank=True, default="", max_length=255),
+        ),
+        migrations.AddConstraint(
+            model_name="bmc",
+            constraint=models.UniqueConstraint(
+                condition=models.Q(power_parameters__project__exists=False),
+                fields=("name",),
+                name="name-unique",
+            ),
+        ),
+    ]
diff --git a/src/maasserver/models/bmc.py b/src/maasserver/models/bmc.py
index 1b282c7..74d34a3 100644
--- a/src/maasserver/models/bmc.py
+++ b/src/maasserver/models/bmc.py
@@ -25,9 +25,11 @@ from django.db.models import (
     Manager,
     ManyToManyField,
     PROTECT,
+    Q,
     SET_DEFAULT,
     SET_NULL,
     TextField,
+    UniqueConstraint,
 )
 from django.db.models.query import QuerySet
 from django.shortcuts import get_object_or_404
@@ -150,6 +152,13 @@ class BMC(CleanSave, TimestampedModel):
         # use a HASH index to get around the size limitation on the content of
         # the indexed object
         indexes = (HashIndex(fields=("power_parameters",)),)
+        constraints = [
+            UniqueConstraint(
+                name="name-unique",
+                fields=["name"],
+                condition=Q(power_parameters__project__exists=False),
+            ),
+        ]
 
     objects = Manager()
 
@@ -190,7 +199,7 @@ class BMC(CleanSave, TimestampedModel):
     )
 
     # Name of the pod.
-    name = CharField(max_length=255, default="", blank=True, unique=True)
+    name = CharField(max_length=255, default="", blank=True, unique=False)
 
     version = TextField(default="", blank=True)
 
diff --git a/src/maasserver/models/tests/test_bmc.py b/src/maasserver/models/tests/test_bmc.py
index bc43e9c..b4b89fe 100644
--- a/src/maasserver/models/tests/test_bmc.py
+++ b/src/maasserver/models/tests/test_bmc.py
@@ -11,6 +11,7 @@ from django.core.exceptions import (
     PermissionDenied,
     ValidationError,
 )
+from django.db import IntegrityError
 from django.db.models.deletion import ProtectedError
 from django.http import Http404
 import petname
@@ -878,6 +879,49 @@ class PodTestMixin:
 
 
 class TestPod(MAASServerTestCase, PodTestMixin):
+    def test_name_project_cluster_uniqueness(self):
+        user = factory.make_User()
+        cluster = factory.make_VMCluster(pods=0)
+        discovered_pod = self.make_discovered_pod()
+        pod1 = Pod(
+            power_type="lxd",
+            power_parameters={"project": factory.make_name("project")},
+        )
+        pod1.sync(discovered_pod, user)
+        pod1.hints.cluster = cluster
+        pod1.save()
+        pod2 = Pod(
+            power_type="lxd",
+            name=pod1.name,
+            power_parameters={"project": pod1.power_parameters["project"]},
+        )
+        self.assertRaises(IntegrityError, pod2.sync, discovered_pod, user)
+
+    def test_name_always_unique_with_no_cluster(self):
+        pod1 = Pod(power_type="virsh", power_parameters={})
+        pod1.save()
+        pod2 = Pod(power_type="virsh", power_parameters={}, name=pod1.name)
+        self.assertRaises(IntegrityError, pod2.save)
+
+    def test_allows_same_name_in_cluster_different_project(self):
+        cluster = factory.make_VMCluster(pods=0)
+        discovered = self.make_discovered_pod()
+        pod1 = Pod(
+            power_type="lxd",
+            power_parameters={"project": factory.make_name("project")},
+        )
+        pod1.save()
+        pod1.sync_hints(discovered.hints, cluster=cluster)
+        pod2 = Pod(
+            power_type="lxd",
+            name=pod1.name,
+            power_parameters={"project": factory.make_name("project")},
+        )
+        pod2.save()
+        pod2.sync_hints(discovered.hints, cluster=cluster)
+        self.assertEqual(pod1.name, pod2.name)
+        self.assertEqual(pod1.hints.cluster_id, pod2.hints.cluster_id)
+
     def test_create_with_pool(self):
         pool = ResourcePool.objects.get_default_resource_pool()
         pod = Pod(power_type="virsh", power_parameters={}, pool=pool)