MAAS

Merge ~cgrabowski/maas:fix_clustered_vmhost_refresh into maas:master

Proposed by Christian Grabowski on 2021-10-19

Status:	Merged
Approved by:	Christian Grabowski on 2021-10-19
Approved revision:	91177217fa910d9ada4f93e86710705fba1a7d90
Merge reported by:	Christian Grabowski
Merged at revision:	91177217fa910d9ada4f93e86710705fba1a7d90
Proposed branch:	~cgrabowski/maas:fix_clustered_vmhost_refresh
Merge into:	maas:master
Diff against target:	0 lines
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
MAAS Lander		Needs Fixing on 2021-10-19
Alexsander de Souza	2021-10-19	Approve on 2021-10-19
Review via email: mp+410464@code.launchpad.net

Commit message

check if pod exists first on sync_vmcluster

Revision history for this message

MAAS Lander (maas-lander) wrote on 2021-10-19:

UNIT TESTS
-b fix_clustered_vmhost_refresh lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: c0a2b587016744b617f874273b33337973d6e6f5

review: Approve

Revision history for this message

Alexsander de Souza (alexsander-souza) wrote on 2021-10-19:

+1, but we should try to refactor this to eliminate some code duplication.

review: Approve

Revision history for this message

Christian Grabowski (cgrabowski) wrote on 2021-10-19:

> +1, but we should try to refactor this to eliminate some code duplication.

These were split out on purpose, while the code is similar, the async one needs to be deferred in a database thread for parts of it, while some of it does not, I suppose there's some common code that could be pulled into a single function, but it's not as simple as deferring the synchronous version to the database thread.

Revision history for this message

MAAS Lander (maas-lander) wrote on 2021-10-19:

UNIT TESTS
-b fix_clustered_vmhost_refresh lp:~cgrabowski/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/11336/console
COMMIT: 3c8db4d6e093b8b0fc7b9c15e3853e1d3d240866