Merge lp:~cern-kicad/kicad/pcb_painter_names into lp:kicad/product

Proposed by Maciej Suminski
Status: Merged
Merged at revision: 4428
Proposed branch: lp:~cern-kicad/kicad/pcb_painter_names
Merge into: lp:kicad/product
Diff against target: 95 lines (+32/-14)
1 file modified
pcbnew/pcb_painter.h (+32/-14)
To merge this branch: bzr merge lp:~cern-kicad/kicad/pcb_painter_names
Reviewer Review Type Date Requested Status
KiCad Lead Developers Pending
Review via email: mp+193561@code.launchpad.net

Description of the change

Added some comments and missing parameter names for pcb_painter.h.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'pcbnew/pcb_painter.h'
2--- pcbnew/pcb_painter.h 2013-10-14 14:13:35 +0000
3+++ pcbnew/pcb_painter.h 2013-11-01 09:09:37 +0000
4@@ -68,6 +68,7 @@
5 CL_TRACKS = 0x4
6 };
7
8+ ///> Determines how zones should be displayed
9 enum DisplayZonesMode {
10 DZ_HIDE_FILLED = 0,
11 DZ_SHOW_FILLED,
12@@ -90,27 +91,44 @@
13 /// @copydoc RENDER_SETTINGS::GetColor()
14 virtual const COLOR4D& GetColor( const VIEW_ITEM* aItem, int aLayer ) const;
15
16+ /**
17+ * Function GetLayerColor
18+ * Returns the color used to draw a layer.
19+ * @param aLayer is the layer number.
20+ */
21 const COLOR4D& GetLayerColor( int aLayer ) const;
22
23 protected:
24- /// @copydoc RENDER_SETTINGS::Update()
25+ ///> @copydoc RENDER_SETTINGS::Update()
26 void update();
27
28- /// Colors for all layers (including special, highlighted & darkened versions)
29+ ///> Colors for all layers (normal)
30 COLOR4D m_layerColors [TOTAL_LAYER_COUNT];
31+
32+ ///> Colors for all layers (highlighted)
33 COLOR4D m_layerColorsHi [TOTAL_LAYER_COUNT];
34+
35+ ///> Colors for all layers (selected)
36 COLOR4D m_layerColorsSel [TOTAL_LAYER_COUNT];
37+
38+ ///> Colors for all layers (darkened)
39 COLOR4D m_layerColorsDark[TOTAL_LAYER_COUNT];
40
41 bool m_sketchModeSelect[TOTAL_LAYER_COUNT];
42+
43+ ///> Flag determining if pad numbers should be visible
44 bool m_padNumbers;
45+
46+ ///> Flag determining if net names should be visible for pads
47 bool m_netNamesOnPads;
48+
49+ ///> Flag determining if net names should be visible for tracks
50 bool m_netNamesOnTracks;
51
52- /// Maximum font size for netnames (and other dynamically shown strings)
53+ ///> Maximum font size for netnames (and other dynamically shown strings)
54 static const double MAX_FONT_SIZE;
55
56- /// Option for different display modes for zones
57+ ///> Option for different display modes for zones
58 DisplayZonesMode m_displayZoneMode;
59 };
60
61@@ -122,7 +140,6 @@
62 class PCB_PAINTER : public PAINTER
63 {
64 public:
65-
66 PCB_PAINTER( GAL* aGal );
67
68 /// @copydoc PAINTER::Draw()
69@@ -142,16 +159,17 @@
70 PCB_RENDER_SETTINGS* m_pcbSettings;
71
72 // Drawing functions for various types of PCB-specific items
73- void draw( const TRACK*, int );
74- void draw( const SEGVIA*, int );
75- void draw( const D_PAD*, int );
76- void draw( const DRAWSEGMENT* );
77- void draw( const TEXTE_PCB*, int );
78- void draw( const TEXTE_MODULE*, int );
79- void draw( const ZONE_CONTAINER* );
80- void draw( const DIMENSION*, int );
81- void draw( const PCB_TARGET* );
82+ void draw( const TRACK* aTrack, int aLayer );
83+ void draw( const SEGVIA* aVia, int aLayer );
84+ void draw( const D_PAD* aPad, int aLayer );
85+ void draw( const DRAWSEGMENT* aSegment );
86+ void draw( const TEXTE_PCB* aText, int aLayer );
87+ void draw( const TEXTE_MODULE* aText, int aLayer );
88+ void draw( const ZONE_CONTAINER* aZone );
89+ void draw( const DIMENSION* aDimension, int aLayer );
90+ void draw( const PCB_TARGET* aTarget );
91 };
92 } // namespace KIGFX
93
94 #endif /* __CLASS_PAINTER_H */
95+