Code review comment for lp:~cern-kicad/kicad/bugfix_1275319

Revision history for this message
Maciej Suminski (orsonmmz) wrote :

It is not my intention to increase the number of bits in m_VisibleElements - I prefer to leave it as it is now, particularly that it is saved as a 32-bit number in .kicad_pcb files and I would like to preserve compatibility (so if older versions expect 32-bit number there - let them have it and do not crash/do weird things on load of PCBs holding 64 bits for elements visiblity). Saving netnames layers visibility is not really crucial, it can be restored basing on visibility settings of appropriate copper layers.
The change from int to long resulted only from the fact that in the back of my head I remember that int is guaranteed to be 16 bits, so maybe on some platforms the code would not run as expected. But as it works on the major platforms then I simply do not insist on changing that.
Anyway - the patch fixes the problem even when m_VisibleElements stays as integer, so what do you think about the rest of the changes?

Regards,
Orson

« Back to merge proposal