Code review comment for lp:~cerberus/nova/nova_notifications

Revision history for this message
Chris Behrens (cbehrens) wrote :

Looks pretty awesome.

Minor nit that I notice in the tests:

test_send_notification uses self.notify_called when you don't need to set this in the instance. Ie, you can just do:

notify_called = False

def mock_notify(cls, *args):
    notify_called = True

Similar thing in the other tests. self.mock_cast and self.test_topic.

« Back to merge proposal