Code review comment for lp:~cerberus/nova/nova_notifications

Revision history for this message
Jay Pipes (jaypipes) wrote :

Nice improvements, Matt!

Little nits:

145 + """ log notifications using nova's default logging system """

Please remove the spaces before and after enclosing """

107 + raise BadPriorityException('%s not in valid priorities' % priority)

Need i18n in the string there...

Other than those tiny things, looks excellent.

Cheers,
jay

review: Needs Fixing

« Back to merge proposal