Nice improvements, Matt!
Little nits:
145 + """ log notifications using nova's default logging system """
Please remove the spaces before and after enclosing """
107 + raise BadPriorityException('%s not in valid priorities' % priority)
Need i18n in the string there...
Other than those tiny things, looks excellent.
Cheers, jay
« Back to merge proposal
Nice improvements, Matt!
Little nits:
145 + """ log notifications using nova's default logging system """
Please remove the spaces before and after enclosing """
107 + raise BadPriorityExce ption(' %s not in valid priorities' % priority)
Need i18n in the string there...
Other than those tiny things, looks excellent.
Cheers,
jay