Mir

Code review comment for lp:~cemil-azizoglu/mir/nested_lifecycle_events

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> 387 + TriggerLifecycleEvent(mir_lifecycle_state_resumed);
> 388 + TriggerLifecycleEvent(mir_lifecycle_state_will_suspend);
> 389 +
> 390 + InSequence seq;
> ...
>
> I'm surprised that sending the events before setting the expectations isn't
> racy.

Actually it is.

Sticking in...

    std::this_thread::sleep_for(std::chrono::seconds(1));

...shouldn't hurt but it does.

review: Needs Fixing

« Back to merge proposal