Mir

Code review comment for lp:~cemil-azizoglu/mir/more-accurate-probing

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

+ const char *argv[] = {"dummy", "--vt"};
+ options.parse_arguments(po, 2, argv);

These are not needed for any of the existing tests and also skew the results since they include a platform specific argument.

TEST_F(ServerPlatformProbeMockDRM, LoadsMesaPlatformWhenDrmDevicePresent)

The test name is now misleading. This should be renamed to LoadsMesaPlatformWhenDrmMasterCanBeAcquired or similar.

review: Needs Fixing

« Back to merge proposal