Code review comment for lp:~cemil-azizoglu/mir/mir-on-x

Nonblocking:
180 + std::runtime_error(msg)) << boost::errinfo_errno(errno));

std::system_error does this in a better-consumable way without the boost::enable_errinfo faffery.

234 + dynamic_cast<EGLImageBufferTextureBinder*>(new DMABufTextureBinder{bo, egl_extensions}) :
235 + dynamic_cast<EGLImageBufferTextureBinder*>(new NativePixmapTextureBinder{bo, egl_extensions})

What's the need for dynamic_cast here? Both DMABufTextureBinder and NativePixmapTextureBinder are statically known to be subclasses of EGLImageBufferTextureBinder.

763 + eglMakeCurrent(egl_dpy, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
764 + eglDestroyContext(egl_dpy, egl_ctx);
765 + eglDestroySurface(egl_dpy, egl_surf);

Funky indentation.

2880 +TEST_F(X11DisplayTest, creates_display_successfully)

I continue to think that this test doesn't test anything valuable, and should be removed.

Otherwise seems sane.