Mir

Code review comment for lp:~cemil-azizoglu/mir/fix-perf-report-surface-name-lp1415305

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Confirmed by manual testing the bug is fixed.

I'm open to finding a nicer solution in future too. Although if we look to the future and find that a window title string is separate to the surface "name" then maybe this is the proper right answer to give a buffer stream a name.

If it's possible to test without major trouble then do. But if this 200 line diff starts to approach 1000 then it's probably not worth the effort (present and future maintenance) to test the surface naming bit.

review: Approve

« Back to merge proposal