Mir

Code review comment for lp:~cemil-azizoglu/mir/fix-1628794

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

> there is an inline comment..

Changed it accordingly.

>
> What happens with IgnoreResponse if the reply never arrives?

I guess the right thing would be to purge the outsanding replies after a timeout. If that were an issue, however, we would have seen it already as the exact code exists in our codebase - take a look at HandleErrorVoid and handle_structured_error in MirConnection. So with the march towards CapnProto, I don't think it's big enough a concern to warrant spending effort at this point.

« Back to merge proposal