Mir

Code review comment for lp:~cemil-azizoglu/mir/add-create-module-context-fn

Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

> *Needs Discussion*
>
> I'm just pondering an alternative approach: adding a method to mg::Platform.
> Vis:
>
> auto create_input_platform(...) -> UniqueModulePtr<input::Platform>
>
> It the user has specified an input platform this can be ignored, otherwise
> call this and if it returns non-nullptr then use the result. Otherwise Mir
> looks for a suitable module elsewhere as currently.

Some anomalies with this approach would be :

- Not sure how this would solve the problem of creating a common context for both graphics and input irrespective of load order.
- Strange to have an "input" related interface in mir::graphics::...
- A graphics only platform would still need to have a create_input_platform() entry point.. confusing IMO.
- Imposes an order in which graphics (first) and input (next) platforms need to be created

« Back to merge proposal