Mir

Code review comment for lp:~cemil-azizoglu/mir/add-create-module-context-fn

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> std::shared_ptr<void> module_context

std::shared_ptr<void> const&, for consistency with the rest of the code (the idea being not to pay the cost of copying the shared_ptr<> unless it's actually needed by the callee).

Looks good otherwise.

review: Needs Fixing

« Back to merge proposal