Merge lp:~cellsoftware/telegram-app/1530698 into lp:telegram-app

Proposed by Paz Chauhan
Status: Merged
Approved by: Jin
Approved revision: 178
Merged at revision: 178
Proposed branch: lp:~cellsoftware/telegram-app/1530698
Merge into: lp:telegram-app
Diff against target: 37 lines (+5/-1)
2 files modified
telegram/app/qml/AccountMessageAction.qml (+5/-0)
telegram/app/qml/components/MessagesListItem.qml (+0/-1)
To merge this branch: bzr merge lp:~cellsoftware/telegram-app/1530698
Reviewer Review Type Date Requested Status
Jin (community) Approve
Ash Approve
Review via email: mp+292817@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ash (ashley-richards) wrote :

I have overviewed Paz's QML code and, to me, it all looks fine.

Revision history for this message
Ash (ashley-richards) :
review: Approve
178. By Paz Chauhan

.po and .pot files reverted

Revision history for this message
Jin (jindallo) wrote :

The code looks good to me,
and verified pass locally.

Thanks for this patch,
I will top-approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'telegram/app/qml/AccountMessageAction.qml'
--- telegram/app/qml/AccountMessageAction.qml 2016-04-17 01:29:55 +0000
+++ telegram/app/qml/AccountMessageAction.qml 2016-04-26 11:27:11 +0000
@@ -2,6 +2,7 @@
2import Ubuntu.Components 1.32import Ubuntu.Components 1.3
3import AsemanTools 1.03import AsemanTools 1.0
4import TelegramQML 1.04import TelegramQML 1.0
5import QtQuick.Window 2.0
56
6Item {7Item {
7 id: message_action8 id: message_action
@@ -41,9 +42,13 @@
41 visible: hasAction42 visible: hasAction
4243
43 Label {44 Label {
45 id: actionText
44 anchors.horizontalCenter: parent.horizontalCenter46 anchors.horizontalCenter: parent.horizontalCenter
47 width: Screen.width * 0.85
48 horizontalAlignment: Text.AlignHCenter
45 fontSize: "small"49 fontSize: "small"
46 color: "#333333"50 color: "#333333"
51 wrapMode: Text.WrapAtWordBoundaryOrAnywhere
47 text: {52 text: {
48 var res = ""53 var res = ""
49 var userName54 var userName
5055
=== modified file 'telegram/app/qml/components/MessagesListItem.qml'
--- telegram/app/qml/components/MessagesListItem.qml 2016-04-06 08:01:54 +0000
+++ telegram/app/qml/components/MessagesListItem.qml 2016-04-26 11:27:11 +0000
@@ -230,7 +230,6 @@
230230
231 Label {231 Label {
232 id: message_text232 id: message_text
233
234 // Taken from messaging-app233 // Taken from messaging-app
235 function parseText(text) {234 function parseText(text) {
236 var phoneExp = /(\+?([0-9]+[ ]?)?\(?([0-9]+)\)?[-. ]?([0-9]+)[-. ]?([0-9]+)[-. ]?([0-9]+))/img;235 var phoneExp = /(\+?([0-9]+[ ]?)?\(?([0-9]+)\)?[-. ]?([0-9]+)[-. ]?([0-9]+)[-. ]?([0-9]+))/img;

Subscribers

People subscribed via source and target branches

to status/vote changes: