Code review comment for lp:~ceejatec/zorba/feature-module-installation
Revision history for this message
| Matthias Brantner (matthias-brantner) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Looks good in general. Only tried compiling so far but didn't install. I would suggest that at least somebody with Windows also tries it.
Minor comments:
- theURIPath (good name?); theXQPath?
- setLibPath or setLibPaths in the public api?
- should we really remove -module-path from zorbacmd but keep it in the public sctx (backwards incompatible?)
- same for ZORBA_MODULES_
Will you add documentation & change log before merging?