I cannot find by reading the code a case where this branch is executed (i.e. a logical path in which we get len(self._connections) >= self._maxconn so I'm wondering if we are not improving dead code here.
Do you have a scenario at hand?
review:Approve
(code review, sometest without being able to exercise that code)
LGTM : the connection must be closed.
But
I cannot find by reading the code a case where this branch is executed (i.e. a logical path in which we get len(self. _connections) >= self._maxconn so I'm wondering if we are not improving dead code here.
Do you have a scenario at hand?