Code review comment for lp:~cdwilson/python-msp430-tools/fix-legacy-input-file-processing

zsquareplusc (zsquareplusc) wrote :

OK, merged.

That legacy_memory modifies the Segment instances is not nice, but I don't feel like rewriting the code where it accesses the data as this is the old BSL implementation anyway. This at least gets the tool working again :-)

review: Approve

« Back to merge proposal