Merge lp:~cbwcjw/midori/fix-bug790270 into lp:midori

Proposed by Chris Wallace
Status: Merged
Merged at revision: 6789
Proposed branch: lp:~cbwcjw/midori/fix-bug790270
Merge into: lp:midori
Diff against target: 34 lines (+6/-1)
1 file modified
midori/midori-browser.c (+6/-1)
To merge this branch: bzr merge lp:~cbwcjw/midori/fix-bug790270
Reviewer Review Type Date Requested Status
Danielle Foré (community) Approve
Midori Devs Pending
Review via email: mp+217543@code.launchpad.net

Description of the change

Bug #790270: add "Add a new bookmark..." to bookmark toolmenu

This adds the same button now to the toolmenu. I'm not specifically sure if this is what was wanted, however.

To post a comment you must log in.
Revision history for this message
Robert Roth (evfool) wrote :

@Daniel Fore, could you please take a look at this branch to see if this is what you had in your mind when you reported this bug?

Revision history for this message
Danielle Foré (danrabbit) wrote :

Yep, this appears to work correctly for me :)

Revision history for this message
Danielle Foré (danrabbit) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'midori/midori-browser.c'
--- midori/midori-browser.c 2014-04-29 00:20:45 +0000
+++ midori/midori-browser.c 2014-04-29 06:43:48 +0000
@@ -3199,10 +3199,13 @@
3199 gtk_container_foreach (GTK_CONTAINER (menu),3199 gtk_container_foreach (GTK_CONTAINER (menu),
3200 (GtkCallback)(gtk_widget_destroy), NULL);3200 (GtkCallback)(gtk_widget_destroy), NULL);
32013201
3202 /* "Import Bookmarks" and "Export Bookmarks" at the top */3202 /* "Add Bookmarks", "Import Bookmarks", and "Export Bookmarks" at the top */
3203 if (id == NULL)3203 if (id == NULL)
3204 {3204 {
3205 GtkWidget* menuitem;3205 GtkWidget* menuitem;
3206 menuitem = gtk_action_create_menu_item (_action_by_name (browser, "BookmarkAdd"));
3207 gtk_menu_shell_append (menu, menuitem);
3208 gtk_widget_show (menuitem);
3206 menuitem = gtk_action_create_menu_item (_action_by_name (browser, "BookmarksImport"));3209 menuitem = gtk_action_create_menu_item (_action_by_name (browser, "BookmarksImport"));
3207 gtk_menu_shell_append (menu, menuitem);3210 gtk_menu_shell_append (menu, menuitem);
3208 gtk_widget_show (menuitem);3211 gtk_widget_show (menuitem);
@@ -3274,6 +3277,7 @@
3274 while ((widget = midori_panel_get_nth_page (MIDORI_PANEL (browser->panel), j++)))3277 while ((widget = midori_panel_get_nth_page (MIDORI_PANEL (browser->panel), j++)))
3275 midori_context_action_add (menu, g_object_get_data (G_OBJECT (widget), "midori-panel-action"));3278 midori_context_action_add (menu, g_object_get_data (G_OBJECT (widget), "midori-panel-action"));
3276 midori_context_action_add (menu, NULL);3279 midori_context_action_add (menu, NULL);
3280 midori_context_action_add_by_name (menu, "BookmarkAdd");
3277 midori_context_action_add_by_name (menu, "BookmarksImport");3281 midori_context_action_add_by_name (menu, "BookmarksImport");
3278 midori_context_action_add_by_name (menu, "BookmarksExport");3282 midori_context_action_add_by_name (menu, "BookmarksExport");
3279 midori_context_action_add_by_name (menu, "ClearPrivateData");3283 midori_context_action_add_by_name (menu, "ClearPrivateData");
@@ -5610,6 +5614,7 @@
5610 "<menuitem action='Trash'/>"5614 "<menuitem action='Trash'/>"
5611 "</menu>"5615 "</menu>"
5612 "<menu action='Bookmarks'>"5616 "<menu action='Bookmarks'>"
5617 "<menuitem action='BookmarksAdd'/>"
5613 "<menuitem action='BookmarksImport'/>"5618 "<menuitem action='BookmarksImport'/>"
5614 "<menuitem action='BookmarksExport'/>"5619 "<menuitem action='BookmarksExport'/>"
5615 "</menu>"5620 "</menu>"

Subscribers

People subscribed via source and target branches

to all changes: