Code review comment for lp:~cbrandily/python-fixtures/cleanup-context

Revision history for this message
Robert Collins (lifeless) wrote :

Thanks for this patch. This is a better, closer to the cause fix. It doesn't address the issue of setUp being fragile though.

Additionally - and I'm sorry about this - you got mislead by the somewhat confusing thing of us having a mirror of the code here: the code is actually on github at https://testing-cabal/fixtures. (LP does have a link to that but its not obvious - I hope I've made it clearer by editing the homepage a bit).

I've put up a patch https://github.com/testing-cabal/fixtures/pull/11 which I think fixes both angles systematically. It will require fixture authors to update, but they can do that incrementally in their own time, and the update is very easy. Reasoning behind this is at https://rbtcollins.wordpress.com/2015/06/22/revisiting-the-fixture-api-handling-leaky-resources/

review: Disapprove

« Back to merge proposal