Hi Liang
This generally looks OK - a couple of minor comments on the change below.
I had a merge conflict when I reviewed - please can you rebase again.
I'd also like to see some unit tests to exercise this configuration option before we land it.
« Back to merge proposal
Hi Liang
This generally looks OK - a couple of minor comments on the change below.
I had a merge conflict when I reviewed - please can you rebase again.
I'd also like to see some unit tests to exercise this configuration option before we land it.