Code review comment for lp:~cbjchen/charms/trusty/openstack-dashboard/enforce-ssl

Revision history for this message
James Page (james-page) wrote :

Hi Liang

This generally looks OK - a couple of minor comments on the change below.

I had a merge conflict when I reviewed - please can you rebase again.

I'd also like to see some unit tests to exercise this configuration option before we land it.

review: Needs Fixing

« Back to merge proposal