Code review comment for ~cberner/maas/+git/maas:lan_channel

Revision history for this message
Newell Jensen (newell-jensen) wrote :

Chris,

Thanks for this merge proposal. We unit test virtually everything in MAAS so you will need to update the unit test for this file as well, test_ipmi_maas_autodetect.py. To run the unit tests for this portion of the code you can issue the command from the branch root directory as such:

bin/test.region metadataserver.user_data.templates.snippets.tests.test_maas_ipmi_autodetect

You will need to run make before this to generate the testing infrastructure.

See HACKING.txt as well for more details on this.

Let me know if you have any further questions. Additionally, Andres was the one that claimed this review so he may have more comments to add as well.

Cheers.

review: Needs Fixing

« Back to merge proposal