Thanks for addressing those issues. Code looks good to me, now, but I'm seeing one test failure:
====================================================================== FAIL: test_get_servers_allows_status_v1_1 (nova.tests.api.openstack.test_servers.ServersTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/brian.waldon/valhalla/nova/servers-search/nova/tests/api/openstack/test_servers.py", line 1184, in test_get_servers_allows_status_v1_1 self.assertEqual(res.status_int, 200) AssertionError: 500 != 200 -------------------- >> begin captured logging << --------------------
...
(nova.api.openstack): TRACE: File "/Users/brian.waldon/valhalla/nova/servers-search/nova/api/openstack/servers.py", line 56, in index (nova.api.openstack): TRACE: servers = self._get_servers(req, is_detail=False) (nova.api.openstack): TRACE: File "/Users/brian.waldon/valhalla/nova/servers-search/nova/api/openstack/servers.py", line 126, in _get_servers (nova.api.openstack): TRACE: context, search_opts=search_opts) (nova.api.openstack): TRACE: File "/Users/brian.waldon/valhalla/nova/servers-search/nova/tests/api/openstack/test_servers.py", line 1174, in fake_get_all (nova.api.openstack): TRACE: [power_state.RUNNING, power_state.BLOCKED]) (nova.api.openstack): TRACE: File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/unittest.py", line 350, in failUnlessEqual (nova.api.openstack): TRACE: (msg or '%r != %r' % (first, second)) (nova.api.openstack): TRACE: AssertionError: [2, 1] != [1, 2] (nova.api.openstack): TRACE: --------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
« Back to merge proposal
Thanks for addressing those issues. Code looks good to me, now, but I'm seeing one test failure:
======= ======= ======= ======= ======= ======= ======= ======= ======= ======= servers_ allows_ status_ v1_1 (nova.tests. api.openstack. test_servers. ServersTest) ------- ------- ------- ------- ------- ------- ------- ------- ------- brian.waldon/ valhalla/ nova/servers- search/ nova/tests/ api/openstack/ test_servers. py", line 1184, in test_get_ servers_ allows_ status_ v1_1 assertEqual( res.status_ int, 200) ------- ------ >> begin captured logging << ------- ------- ------
FAIL: test_get_
-------
Traceback (most recent call last):
File "/Users/
self.
AssertionError: 500 != 200
-------
...
(nova.api. openstack) : TRACE: File "/Users/ brian.waldon/ valhalla/ nova/servers- search/ nova/api/ openstack/ servers. py", line 56, in index openstack) : TRACE: servers = self._get_ servers( req, is_detail=False) openstack) : TRACE: File "/Users/ brian.waldon/ valhalla/ nova/servers- search/ nova/api/ openstack/ servers. py", line 126, in _get_servers openstack) : TRACE: context, search_ opts=search_ opts) openstack) : TRACE: File "/Users/ brian.waldon/ valhalla/ nova/servers- search/ nova/tests/ api/openstack/ test_servers. py", line 1174, in fake_get_all openstack) : TRACE: [power_ state.RUNNING, power_state. BLOCKED] ) openstack) : TRACE: File "/System/ Library/ Frameworks/ Python. framework/ Versions/ 2.6/lib/ python2. 6/unittest. py", line 350, in failUnlessEqual openstack) : TRACE: (msg or '%r != %r' % (first, second)) openstack) : TRACE: AssertionError: [2, 1] != [1, 2] openstack) : TRACE: ------- ------- >> end captured logging << ------- ------- -------
(nova.api.
(nova.api.
(nova.api.
(nova.api.
(nova.api.
(nova.api.
(nova.api.
(nova.api.
(nova.api.
-------
------- ------- ------- ------- ------- ------- ------- ------- ------- -------