Lines 8-15: if min_count is specified, but no max_count, then at line 14, min_count will be some integer, and max_count will be None. Line 15 will then set min_count to None, too. Is that the desired behavior? Wouldn't the logic used in lines 94-95 make more sense?
Lines 45-51: as long as you're changing that line, can you fix the wonky indentation of the continued lines to use one of the standards for nova? Two levels (i.e., 8 spaces) is preferred, but you can also do the 'align with the item in the main line' approach. The current indentation uses something apparently random.
Lines 168-174: same as above.
Line 485: The log message sounds incorrect; instead of saying "ran out of hosts after weighing", it should probably say "no available hosts after filtering" or something like that.
Lines 8-15: if min_count is specified, but no max_count, then at line 14, min_count will be some integer, and max_count will be None. Line 15 will then set min_count to None, too. Is that the desired behavior? Wouldn't the logic used in lines 94-95 make more sense?
Lines 45-51: as long as you're changing that line, can you fix the wonky indentation of the continued lines to use one of the standards for nova? Two levels (i.e., 8 spaces) is preferred, but you can also do the 'align with the item in the main line' approach. The current indentation uses something apparently random.
Lines 168-174: same as above.
Line 485: The log message sounds incorrect; instead of saying "ran out of hosts after weighing", it should probably say "no available hosts after filtering" or something like that.