Code review comment for lp:~cavalier/lightdm/stop-after-unlock

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Hi Peter,

As discussed in bug 1005813 the cause of this problem turned out to be something else. It should be fixed in revision 1623 [1].

Note that the proposed change was not correct because it could have destroyed the display before the switch had occurred. LightDM destroys greeters once a switch occurs to avoid this problem.

Thanks for taking the time to make the patch and diagnose the problem!

[1] http://bazaar.launchpad.net/~lightdm-team/lightdm/trunk/revision/1623

review: Disapprove

« Back to merge proposal