Code review comment for lp:~catch-drupal/pressflow/load_cache

Revision history for this message
Narayan Newton (nnewton-drupal) wrote :

Hi Nathan,

I noticed a small issue in the user_save hook which was preventing user_save's from completing on a test site. A patch is below:

=== modified file 'modules/user/user.module'
--- modules/user/user.module 2010-10-25 02:49:05 +0000
+++ modules/user/user.module 2010-12-06 19:06:19 +0000
@@ -265,10 +265,10 @@

   if ($hook_module !== FALSE) {
     $function = $hook_module . '_' . $hook;
- $return = $function($account, $array = array(), $category = 'account');
+ $return = $function($account, $array, $category);
   }
    else {
- $return = _user_save_direct($account, $array = array(), $category = 'account');
+ $return = _user_save_direct($account, $array, $category);
   }
   return $return;
 }

review: Needs Fixing

« Back to merge proposal