Installer for Minecraft

Merge lp:~cassidyjames/minecraft/fix-1335190 into lp:minecraft

  1. fix-1335190
  2. Merge into trunk
Proposed by Cassidy James Blaede
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp:~cassidyjames/minecraft/fix-1335190
Merge into: lp:minecraft
Diff against target: 19 lines (+2/-2)
1 file modified
minecraft.desktop (+2/-2)
To merge this branch: bzr merge lp:~cassidyjames/minecraft/fix-1335190
Reviewer Review Type Date Requested Status
Cody Garver Needs Fixing
Review via email: mp+224872@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

We discussed a better exec line but I can't remember what it was. Was it just java -jar /usr/share/minecraft/minecraft.jar ?

review: Needs Fixing

Unmerged revisions

10. By Cassidy James Blaede

Fix bug 1335190 by removing RAM XMODIFIERS from launcher.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'minecraft.desktop'
--- minecraft.desktop 2013-07-07 08:01:16 +0000
+++ minecraft.desktop 2014-06-27 16:30:12 +0000
@@ -3,7 +3,7 @@
3Name=Minecraft3Name=Minecraft
4GenericName=Game4GenericName=Game
5Comment=Break and place blocks to build imaginative things5Comment=Break and place blocks to build imaginative things
6Exec=sh -c "XMODIFIERS= java -Xmx2048M -Xms512M -cp /usr/share/minecraft/minecraft.jar net.minecraft.bootstrap.Bootstrap"6Exec=java -cp /usr/share/minecraft/minecraft.jar net.minecraft.bootstrap.Bootstrap
7Icon=minecraft7Icon=minecraft
8Categories=Game8Categories=Game
9StartupNotify=true9StartupNotify=true
@@ -20,4 +20,4 @@
2020
21[Desktop Action Wiki]21[Desktop Action Wiki]
22Name=_Wiki22Name=_Wiki
23Exec=xdg-open http://www.minecraftwiki.net/23Exec=xdg-open http://www.minecraftwiki.net/
24\ No newline at end of file24\ No newline at end of file

Subscribers

People subscribed via source and target branches