Code review comment for lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-12

Revision history for this message
Carlos Jose Mazieri (carlos-mazieri) wrote :

About the comment:
"But it's not clear to me when existing context should be closed and new created etc."

It is not clear to me either, I could not find good documentation of "libsmbclient", this source code is based on "libsmbclient" examples and some own tests, all operations require a "context", but it is not clear if a "context" can be reused for example doing a rename after writing data into a file, that is the reason why some methods always create a context as example in SmbLocationItemFile::rename(const QString& oldname, const QString& newName).

« Back to merge proposal