Code review comment for lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-11

Revision history for this message
Carlos Jose Mazieri (carlos-mazieri) wrote :

About the comment:

   166 if (fd == 0)
   167 {
   168 - fd = openFile(context, smb_path);
   169 + openFile(context,smb_path);

It is really a mistake, the function still works most of the times due to next "if" that still tries to get a valid descriptor from the parent directory.

That will be fixed.

Other comment:

   153 + if (!currentPathWithDot.isEmpty())
   154 + {
   155 + content.append(currentPathWithDot);
   156 + }
   157 + if (!currentpathWithDotDot.isEmpty())
   158 + {
   159 + content.append(currentpathWithDotDot);
   160 + }

it will be improved.

Thanks.

« Back to merge proposal