Code review comment for lp:~carlos-mazieri/ubuntu-filemanager-app/samba-actions-03

Revision history for this message
Arto Jalkanen (ajalkane) wrote :

Several places that this comment applies to:

Why don't you use d(setParentIfRelative(folderName)); here also?

My understanding of C++ is that is more efficient than using assignment to created object. With assignment the object is first created, and then it's operator=() called to set instance's variables. If using directly copy constructor, the compiler can optimize the creation of the object.

I'll approve this nevertheless as it's a minor thing and you can consider yourself whether to change it or top-approve this change.

review: Approve

« Back to merge proposal