Merge lp:~carla-sella/ubuntu-rssreader-app/fixed-tests-for-feed-checkbox into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Carla Sella
Status: Merged
Approved by: Nicholas Skaggs
Approved revision: 350
Merged at revision: 352
Proposed branch: lp:~carla-sella/ubuntu-rssreader-app/fixed-tests-for-feed-checkbox
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 25 lines (+2/-2)
2 files modified
feeds/AppendFeedPage.qml (+1/-1)
tests/autopilot/shorts_app/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~carla-sella/ubuntu-rssreader-app/fixed-tests-for-feed-checkbox
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Roman Shchekin Pending
Nicholas Skaggs Pending
Review via email: mp+245301@code.launchpad.net

Commit message

Autopilot tests for Ubuntu Rssreader App

Description of the change

Fixed broken tests due to introduction of feed checkbox.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Carla Sella (carla-sella) wrote :

This fixes failing of various tests where the checkbox is not beeing selected while adding a new feed.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Awesome. I should have looked through this first. Thanks Carla!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'feeds/AppendFeedPage.qml'
--- feeds/AppendFeedPage.qml 2014-09-20 10:51:29 +0000
+++ feeds/AppendFeedPage.qml 2014-12-21 20:59:18 +0000
@@ -207,7 +207,7 @@
207 control: CheckBox {207 control: CheckBox {
208 anchors.verticalCenter: parent.verticalCenter208 anchors.verticalCenter: parent.verticalCenter
209209
210 objectName: "feedCheckbox"210 objectName: "feedCheckbox-" + model.title
211 onCheckedChanged: {211 onCheckedChanged: {
212 searchResultsModel.setProperty(index, "isSelected", checked)212 searchResultsModel.setProperty(index, "isSelected", checked)
213 if (checked)213 if (checked)
214214
=== modified file 'tests/autopilot/shorts_app/__init__.py'
--- tests/autopilot/shorts_app/__init__.py 2014-12-16 19:51:03 +0000
+++ tests/autopilot/shorts_app/__init__.py 2014-12-21 20:59:18 +0000
@@ -359,7 +359,7 @@
359359
360 def _check_result(self, result):360 def _check_result(self, result):
361 results_list = self._get_results_list()361 results_list = self._get_results_list()
362 results_list.click_element('feedpagelistitem-{}'.format(result))362 results_list.click_element('feedCheckbox-{}'.format(result))
363363
364364
365class ChooseTopicPage(Page):365class ChooseTopicPage(Page):

Subscribers

People subscribed via source and target branches