Merge lp:~carla-sella/ubuntu-rssreader-app/fixed-all-tests into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by Carla Sella
Status: Merged
Approved by: Roman Shchekin
Approved revision: 99
Merged at revision: 99
Proposed branch: lp:~carla-sella/ubuntu-rssreader-app/fixed-all-tests
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 44 lines (+12/-2)
2 files modified
rssreader-app.qml (+1/-1)
tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py (+11/-1)
To merge this branch: bzr merge lp:~carla-sella/ubuntu-rssreader-app/fixed-all-tests
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+189705@code.launchpad.net

Commit message

Autopilot tests for ubuntu-rssreader-app.

Description of the change

Fixed all tests after upstream sdk version.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'rssreader-app.qml'
--- rssreader-app.qml 2013-10-07 12:49:31 +0000
+++ rssreader-app.qml 2013-10-07 20:53:58 +0000
@@ -125,9 +125,9 @@
125 }125 }
126126
127 ToolbarButton {127 ToolbarButton {
128 objectName: "changemodebutton"
128 action: Action {129 action: Action {
129 id: changeModeAction130 id: changeModeAction
130
131 text: pageStack.isListView ? i18n.tr("Grid View") : i18n.tr("List view")131 text: pageStack.isListView ? i18n.tr("Grid View") : i18n.tr("List view")
132 iconSource: pageStack.isListView ? Qt.resolvedUrl("./icons_tmp/view-fullscreen.svg") : Qt.resolvedUrl("./icons_tmp/view-fullscreen.svg")132 iconSource: pageStack.isListView ? Qt.resolvedUrl("./icons_tmp/view-fullscreen.svg") : Qt.resolvedUrl("./icons_tmp/view-fullscreen.svg")
133 onTriggered: {133 onTriggered: {
134134
=== modified file 'tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py'
--- tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py 2013-10-06 13:07:13 +0000
+++ tests/autopilot/ubuntu_rssreader_app/tests/test_rssreader.py 2013-10-07 20:53:58 +0000
@@ -304,7 +304,7 @@
304 #open toolbar304 #open toolbar
305 toolbar = self.main_view.open_toolbar()305 toolbar = self.main_view.open_toolbar()
306306
307 #click on list view toolbar button307 #click on refresh toolbar button
308 toolbar.click_button("rsspagerefreshbutton")308 toolbar.click_button("rsspagerefreshbutton")
309309
310 #wait for any updates to finish before continuing tests310 #wait for any updates to finish before continuing tests
@@ -315,6 +315,16 @@
315 lambda:self.main_view.get_canonical_tab,315 lambda:self.main_view.get_canonical_tab,
316 Eventually(NotEquals(None)))316 Eventually(NotEquals(None)))
317317
318 #open toolbar
319 toolbar = self.main_view.open_toolbar()
320
321 #click on list view toolbar button
322 toolbar.click_button("changemodebutton")
323
324 #verify we are on the CanonicalTopic Tab
325 canonicalTab = self.main_view.get_canonical_tab()
326 self.assertThat(lambda: canonicalTab.visible, Eventually(Equals(True)))
327
318 #select Canonical feed328 #select Canonical feed
319 canonicalFeed = self.main_view.get_canonical_feed_in_feedlist()329 canonicalFeed = self.main_view.get_canonical_feed_in_feedlist()
320 self.assertThat(canonicalFeed, NotEquals(None))330 self.assertThat(canonicalFeed, NotEquals(None))

Subscribers

People subscribed via source and target branches