Code review comment for lp:~carla-sella/ubuntu-calendar-app/calendar-app

Revision history for this message
Olivier Tilloy (osomon) wrote :

Please do not re-use a merge request that was already merged. It’s ok to re-use the same branch (although most of the time it makes sense to start from a new branch), but then submit a new MR.

This is not the right approach. If you need to ensure that a text field has active focus before inputting text in it, do something like that:

    self.pointing_device.click_object(field)
    field.activeFocus.wait_for(True)
    self.keyboard.type(text)
    self.assertThat(field.text, Eventually(Equals(text)))

Also note that I’m addressing similar issues in this test case (it’s failing when run on devices) there: https://code.launchpad.net/~osomon/ubuntu-calendar-app/fix-ap-tests-new-event/+merge/180847. I’d appreciate if you could review it. Thanks!

review: Disapprove

« Back to merge proposal