Code review comment for lp:~carifio/seahorse/seahorse-remove-broken-help-buttons

Revision history for this message
Mike Carifio (carifio) wrote :

[IMPACT]

 * There are two help buttons on various dialogs that run
   yelp with non-existant pages.

 * This bug looks bad and mars the experience for end users.
   OEMs don't like that.

 * The fix removes the chance for error by making the help
   buttons invisible.

[TESTCASE]

 * seahorse > (Passsword and Keyss) > [tab] Passwords > Passwors:
   default> [right-click] Properties > "Passwords:default"
   > (dialog window "Passwords:default") > Keyring >
   Name:=default, Created:=(empty) > Help > (Help) > "PageNotFound": >
   The page 'gkr-keyring' was not found in the document 'ghelp:seahorse'.

[Regression Potential]

 * In the worst case scenario, setting the buttons invisible in the glade
   xml could be overridden by seahorse code. The help buttons would then be
   visible. The end user could reproduce the problem. This would mar
   the end user experience. But it wouldn't stop seahorse from doing
   its job.

« Back to merge proposal