Code review comment for lp:~cardinot/stellarium/MeteorShower

Revision history for this message
Marcos Cardinot (cardinot) wrote :

> >Could you also push the 'stellarium-website' branch to the SF?
>
> Yes, but not today

Ok, but have in mind that if your auto-updates is enabled, the new catalog will be replaced by the old one. (it explains why LEO was invalid for you, even after a fresh build)

> I don't understand your last 2 commits. Plugins should not store data into
> main data directory.

Yeah, you're right! I reverted both commits!

The copy from qrc is working fine. As I said, I was just with my auto-updates enabled, so, after copying the right file, I was replacing it with the old catalog from the web (which is outdated with the "*" issue)... that was the reason why I've thought that the copy was not being done correctly - my bad! - **1000 facepalms to me!** =D

« Back to merge proposal