Code review comment for lp:~cardinot/stellarium/MeteorShower

Revision history for this message
Marcos Cardinot (cardinot) wrote :

Hi Alex,
thanks for your review!

> Inconsistent behaviour in GUI: "Show buttons on toolbar" ignores settings.

fixed!

> Where is "Save settings" button

Now we just save things automatically =D
Since most software have the same behavior, it's far more intuitive than forcing users to click on "save" all the time.

If a user goes to the settings dialog, set something (mainly options like: 'enable buttons', 'enable plugin at startup', colors etc) and closes Stellarium... I bet $1.000.000.000 dollars that he would expect to see their settings there again - so, why ask for save?

> and where is Leonides? :)

please, update your catalog =D

> And I don't see any meteors :'(

could you check it for a radiant with a high ZHR please? (or even set some data on the catalog, only for tests)

« Back to merge proposal