> The changes you made to test_opening_new_page_enables_back_button() and
> test_navigating_back_enables_forward_button() are not semantically equivalent:
>
> 141 - self.assertThat(back_button.enabled,
> Eventually(Equals(True)))
> 143 + self.main_window.go_back()
> 144 + self.assert_home_page_eventually_loaded()
>
> We don’t want to actually go back, we only want to verify that the back button
> is *eventually* enabled (which the go_back() method doesn’t do). And the
> is_back_button_enabled() method doesn’t contemplate a possible delay (that
> would translate into the use of an Eventually() matcher).
I renamed the tests and added waits in the go methods.
The tests pass here, and I've triggered a new jenkins run to confirm that.
> The changes you made to test_opening_ new_page_ enables_ back_button( ) and _back_enables_ forward_ button( ) are not semantically equivalent: (back_button. enabled, Equals( True))) window. go_back( ) home_page_ eventually_ loaded( ) button_ enabled( ) method doesn’t contemplate a possible delay (that
> test_navigating
>
> 141 - self.assertThat
> Eventually(
> 143 + self.main_
> 144 + self.assert_
>
> We don’t want to actually go back, we only want to verify that the back button
> is *eventually* enabled (which the go_back() method doesn’t do). And the
> is_back_
> would translate into the use of an Eventually() matcher).
I renamed the tests and added waits in the go methods.
The tests pass here, and I've triggered a new jenkins run to confirm that.