Code review comment for lp:~canonical-platform-qa/url-dispatcher/fake_dispatcher

Revision history for this message
Ted Gould (ted) wrote :

The problem is that you don't know that it's going to be "../../" always. I could do:

cmake . ; make

Or I could do:

mkdir build ; cd build ; cmake .. ; make

Or I could do:

mkdir -p foo/bar/foo/bar ; cd foo/bar/foo/bar ; cmake ../../../.. ; make

The way that is kept track of is the variables in CMake. So when people starting doing things like cross compilation the variables get complex.

I figured command line is easier, but setting an environment variable works as well. Just some something that can get information from the build system as the path to the binaries that isn't hard coded. You can also make the python file a .py.in and have the build system do the substitution.

« Back to merge proposal