Code review comment for lp:~canonical-platform-qa/url-dispatcher/fake_dispatcher

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

> Some discussion on IRC putting here for tracking:
>
> * The tests need to be run by CTest not by debian/rules
> * We shouldn't override autotest here to run it under dbus, that should be in
> the individual test
> * The package shouldn't have a build-dep on a binary it produces

All good points - CMake is proving very difficult to work with at the moment though. I updated the branch with some CMake changes, but they don't result in my python code being copied to build/tests/url_dispatcher_testability as I'd expect.

From reading about FindPythonLibs, I think it's intended as being useful in the case where one wants to create C/C++ extensions for python. I don't think it helps in this situation - all I have is some python modules that I want to test and install.

« Back to merge proposal