Code review comment for lp:~canonical-platform-qa/ubuntu-ui-toolkit/textfield-use-osk

Revision history for this message
Cris Dywan (kalikiana) wrote :

+ if is_maliit_process_running():
+ configure_osk_settings()
+ restart_maliit_with_testability()
+ return input.Keyboard.create('OSK')
+ else:
+ return input.Keyboard.create()
+
+
+def restart_maliit_with_testability():
+ """Restart maliit-server with testability enabled."""
+ if is_maliit_process_running():

The if..running is redundant given that restart only occurs if that's already the case. Also the function name inherently requires that.

+ # This is needed to work around launchpad.net/bugs/1248913
+ time.sleep(5)

Please use https so bug links can actually be opened.

review: Needs Fixing

« Back to merge proposal