Code review comment for lp:~canonical-platform-qa/ubuntu-test-cases/health-check_adding-nfss-file-generator-to-dep8

Revision history for this message
Allan LeSage (allanlesage) wrote :

These tests are still running on my mako but I was able to generate a large JSON file on the early output using veebers' script.

I have only teensy-minor comments here, balanced against our interest in landing this--you might add docstrings where they're missing, also maybe just use strip() instead of replace()? Approving nonetheless :) . . . .

review: Approve

« Back to merge proposal