Code review comment for lp:~canonical-platform-qa/ubuntu-system-tests/clean-install

Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

Hi Richard, I still need to go through the entire mp but I rather not move the imports. Local imports, as a rule, should be used only if it's extremely necessary because for example the module that you are importing do a lot of processing causing performance issues so you actually want to import the module only if it's going to be used.
Another problem of moving the imports is that they could hide circular dependencies

review: Needs Fixing

« Back to merge proposal