Code review comment for lp:~canonical-platform-qa/ubuntu-system-tests/clean-install
Revision history for this message
| Richard Huddie (rhuddie) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> The tests are passing and the whole change works. I see that the code is
> getting more complex with this change, perhaps we could research if there is
> an alternative to list the tests and avoid removing all these imports. What do
> you think?
One thing to remember is that we are planning to remove at least some of the external dependencies, starting with unity8. So where there are some helpers that are wrappers around unity8, these would be replaced with the full implementation within ubuntu-system-tests itself. So this mp is making a start at localising those changes.
But that won't be the case for all of the imports, i.e. ubuntuuitoolkit and selenium. The only other way I can think of for that would be to do the imports in a try block and catch the ImportError exception, but that could lead to the case where a genuine import error on the device gets hidden. Have you any other thoughts?