Code review comment for lp:~canonical-platform-qa/ubuntu-system-tests/app-launch-introspect

The reason for doing this way is to write the tests without knowledge of the type of app being used. - Hence using the config value.

Although the app-launch tests could be implemented with snap/deb specific knowledge, it wouldn't be good to have a suite of sanity or regression tests where we need to have specific test cases for specific app versions. - The way I see it is you would want to run a sanity suite on a deb image for deb apps and then run exactly the same set of tests on same image for snap apps. With the current way that would just mean changing the config value and re-running the same set of tests on same image. Similarly for a snap based image, you would want to run the suite using snap apps only.

The jenkins jobs I am creating will do this from a single job. See: https://code.launchpad.net/~canonical-platform-qa/qa-jenkins-jobs/ust-add-app-modes/+merge/319313

I'm not sure if I understood your concerns correctly or not, what do you think?