Code review comment for lp:~canonical-platform-qa/ubuntu-ota-tests/upgrade

Revision history for this message
Christopher Lee (veebers) wrote :

Just a couple of comments re: docs and logging. The code looks really good.
A note that we really need to get adb-reboot-to-recovery upstreamed so we're not hosting a fork.

I attempted to run the code but experienced what looked like a timeout error (Potentially due to the internet connection issues I currently have, will try again later tonight.)

If other people can successfully run this code then I would say this would be an approve (if the mentioned documentation is added) as we can iterate on the failure issue.

review: Needs Fixing

« Back to merge proposal