Code review comment for lp:~canonical-platform-qa/ubuntu-ota-tests/thinkingoutloud-wrapper-reflash-script

Revision history for this message
Federico Gimenez (fgimenez) wrote :

Works great, only two issues:

* The test_apply_update_noop is triggering the update because of it has an update available after reflashing to rev-1; we should add a guard as in [1], something like:

  @unittest.skipIf(is_update_available(),
                  'Update available, would be applied')

* There's a flake8 error in ./ubuntu_ota_tests/hooks.py:31, a file that hasn't been modified by this mp, don't know how it got there :)

Thanks,

[1] https://code.launchpad.net/~canonical-platform-qa/ubuntu-ota-tests/dbus-upgrade/+merge/253423

review: Needs Fixing

« Back to merge proposal