Code review comment for lp:~canonical-platform-qa/ubuntu-ota-tests/thinkingoutloud-wrapper-reflash-script

Revision history for this message
Richard Huddie (rhuddie) wrote :

I've made updates to now use nmcli to setup the wifi connection. This is called using adt-run --setup-command option. During testing I found that if the network connection already exists, adt-run would fail becaue nmcli reported a failure, although it was not an error that would cause any issues. So that is why the nmcli command always reports true. But under normal use this should never be an issue as the device is just reflashed. I also set the default revision to -1 and added a 10 minute timeout for each test execution.

« Back to merge proposal