Merge lp:~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience into lp:ubuntu-autopilot-tests/ubuntu-experience-tests

[Omer Akram]

Automate Launcher to Messaging App experience.

[Omer Akram (om26er)]

While the code is ready, this branch depends on four other branches to be merged.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:26
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/17/
Executed test runs:
    ABORTED: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1692/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2733/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/17/rebuild

review: Needs Fixing (continuous-integration)

[lp:~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience]

27. By Omer Akram on 2014-07-08

commit in working state, will need to adapt to use helpers from address-book-app once they are moved there.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:27
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/18/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1706/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2749/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/18/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

103 + messaging_app = helpers.get_proxy_object_by_process_name(
104 + 'messaging-app',
105 + emulator_base=messaging_emulators.MainView
106 + )

Just as with Brendan's branch, the only emulator_base that we must be using is the one from the toolkit. Definitely not a MainView. There's something wrong here.

107 + messaging_app.start_new_message()
108 + messaging_app.type_contact_phone_num('3333333')
109 + messaging_app.type_message('Hello user!')
110 + messaging_app.click_send_button()

This needs to be wrapped in a helper on the messaging app that's called something like: def send_message(recipients, text)

review: Needs Fixing

[lp:~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience]

28. By Omer Akram on 2014-07-10

don;t alter launcher icons go with stock

29. By Omer Akram on 2014-07-10

python3 ready

30. By Omer Akram on 2014-07-10

revert the change to get_proxy_object_by_process_name

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:30
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/21/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1827/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/21/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/21/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/21/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2914/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/21/rebuild

review: Needs Fixing (continuous-integration)

[lp:~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience]

31. By Omer Akram on 2014-07-10

use the helper from message_app to send message instead of duplicating the code

32. By Omer Akram on 2014-07-10

use helper from the messaging_app to send message

33. By Omer Akram on 2014-07-10

flake8

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:33
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/22/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1829
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/22
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2090
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2916
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2916/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9654

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/22/rebuild

review: Needs Fixing (continuous-integration)

[lp:~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience]

34. By Omer Akram on 2014-07-11

also depend on messaging-app-autopilot

35. By Omer Akram on 2014-07-11

create a method to add contact

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:35
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/23/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1857
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/23
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2115
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2953
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2953/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9690

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/23/rebuild

review: Needs Fixing (continuous-integration)

[Brendan Donegan (brendan-donegan)]

I'm missing how this code implements the use case in the linked bug:
https://bugs.launchpad.net/ubuntu-autopilot-tests/+bug/1328921. It's supposed to use the quicklist, but as far as I can tell it just fills in the details and sends the message.

review: Needs Information

[lp:~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience]

36. By Omer Akram on 2014-07-22

adapt to contact fixture in address-book-service instead of doing that stuff in our code

37. By Omer Akram on 2014-07-22

merge trunk

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:37
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/27/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2337/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/27
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2520/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3548
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3548/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10241

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/27/rebuild

review: Needs Fixing (continuous-integration)

[lp:~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience]

38. By Omer Akram on 2014-07-22

fix test as suggested by brendand

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/28/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2345/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/28
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2528/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3558
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3558/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10251

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/28/rebuild

review: Needs Fixing (continuous-integration)

[Brendan Donegan (brendan-donegan)]

What is this 'select' option in send_message? I don't see it in messaging-app trunk. I think rather than just calling send_message you want to use the helper to compose a new message (start_new_message), then type in the MultiRecipientInput. You'll need a helper for that based on the one I'm adding here: https://code.launchpad.net/~canonical-platform-qa/messaging-app/more_helpers_test/+merge/227781. That's depending on your address-book-service helper so once that gets merged we can merge that one, then merge this one.

review: Needs Fixing

Unmerged revisions

38. By Omer Akram on 2014-07-22

fix test as suggested by brendand

37. By Omer Akram on 2014-07-22

merge trunk

36. By Omer Akram on 2014-07-22

adapt to contact fixture in address-book-service instead of doing that stuff in our code

35. By Omer Akram on 2014-07-11

create a method to add contact

34. By Omer Akram on 2014-07-11

also depend on messaging-app-autopilot

33. By Omer Akram on 2014-07-10

flake8

32. By Omer Akram on 2014-07-10

use helper from the messaging_app to send message

31. By Omer Akram on 2014-07-10

use the helper from message_app to send message instead of duplicating the code

30. By Omer Akram on 2014-07-10

revert the change to get_proxy_object_by_process_name

29. By Omer Akram on 2014-07-10

python3 ready

=== modified file 'debian/control'
--- debian/control	2014-07-03 05:13:26 +0000
+++ debian/control	2014-07-22 19:54:10 +0000
@@ -21,6 +21,8 @@
          ubuntu-ui-toolkit-autopilot,
          unity8-autopilot,
          url-dispatcher-tools,
+         messaging-app-autopilot,
+         address-book-service-testability,
 Description: Ubuntu user experience Autopilot tests
  This package provides a set of autopilot tests for testing
  the inter-app integration under Unity8

=== modified file 'ubuntu_experience_tests/helpers.py'
--- ubuntu_experience_tests/helpers.py	2014-06-19 17:46:15 +0000
+++ ubuntu_experience_tests/helpers.py	2014-07-22 19:54:10 +0000
@@ -108,7 +108,7 @@
 
     """
     return get_proxy_object_for_existing_process(
-        _get_pid_by_name(proc_name),
+        pid=_get_pid_by_name(proc_name),
         emulator_base=_get_emulator_base(proc_name)
     )
 

=== added file 'ubuntu_experience_tests/tests/test_user_experiences.py'
--- ubuntu_experience_tests/tests/test_user_experiences.py	1970-01-01 00:00:00 +0000
+++ ubuntu_experience_tests/tests/test_user_experiences.py	2014-07-22 19:54:10 +0000
@@ -0,0 +1,53 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+#
+# Copyright 2014 Canonical Ltd.
+# Author: Omer Akram <[e-mail]>
+#
+# This file is part of ubuntu-experience-tests.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>
+
+from unity8 import process_helpers
+from unity8.shell import tests, disable_qml_mocking
+
+from address_book_service import fixture_setup as contact_fixture
+from messaging_app import fixture_setup as messaging_fixture
+from messaging_app.emulators import MainView
+
+from ubuntu_experience_tests import helpers
+
+
+class LauncherSendSMS(tests.UnityTestCase):
+
+    def setUp(self):
+        self.useFixture(messaging_fixture.MessagingTestEnvironment())
+        self.useFixture(contact_fixture.AddressBookServiceDummyBackend())
+        super(LauncherSendSMS, self).setUp()
+
+    @disable_qml_mocking
+    def test_launch_app_and_send_sms_to_contact(self):
+        """Launch app from launcher and send sms to a contact."""
+        self.unity_proxy = self.launch_unity()
+        process_helpers.unlock_unity(self.unity_proxy)
+        self.main_window.launch_application('messaging-app')
+
+        messaging_app = helpers.get_proxy_object_by_process_name(
+            'messaging-app',
+        )
+        messaging_app_proxy = messaging_app.select_single(MainView)
+        phone_num = 'UX User'
+        message = 'Hi!'
+        bubble = messaging_app_proxy.send_message(
+            phone_num, message, select=True)
+
+        self.assertProperty(bubble, visible=True)